[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

[via GitHub]

stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303627276


##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -567,6 +575,7 @@ public static class NodeConfigBuilder {
     private String defaultZkHost;
     private Set<Path> allowPaths = Collections.emptySet();
     private List<String> allowUrls = Collections.emptyList();
+    private boolean hideStackTrace = false;

Review Comment:
   hmm, this doesn't look right :) it will now ignore the builder value. line 
616 needs to be 
   
   ```
   private boolean hideStackTrace = Boolean.getBoolean("solr.hideStackTrace");
   ```
   
   and line 190 needs to be as before
   ```
   this.hideStackTraces = hideStackTraces
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org