dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1310619260
##########
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##########
@@ -32,7 +33,7 @@ public static void setDbInstance(SolrQueryRequest req, String
coreOrColl) {
}
public static void ifNotNoop(Span span, Consumer<Span> consumer) {
- if (span != null && !(span instanceof NoopSpan)) {
+ if (span != null && !(span instanceof NoopSpan) && !(span instanceof
SimplePropagatorSpan)) {
Review Comment:
Arguably, SimplePropagatorSpan should implement NoopSpan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
