dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1318070066
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1341,5 +1349,10 @@ public Builder withDefaultClusterProperty(String key,
String value) {
cluster.put(key, value);
return this;
}
+
Review Comment:
Can you please add javadoc here; it may not be obvious what it does and why
a test might want to set it.
I'm thinking maybe:
> Disables the default/built-in simple trace ID generation/propagation. For
example if you want to use a MockTracer or a "real" Tracer, you'll need to
call this so that it doesn't displace the Tracer you want to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
