stillalex commented on code in PR #1884:
URL: https://github.com/apache/solr/pull/1884#discussion_r1315827445
##########
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##########
@@ -239,7 +239,13 @@ private void dispatch(
if (log.isDebugEnabled()) {
log.debug("User principal: {}", request.getUserPrincipal());
}
- TraceUtils.setUser(span, String.valueOf(request.getUserPrincipal()));
+ final String principalName;
+ if (request.getUserPrincipal() != null) {
+ principalName = request.getUserPrincipal().getName();
+ } else {
+ principalName = null;
+ }
+ TraceUtils.setUser(span, String.valueOf(principalName));
Review Comment:
in trying to keep the original design of the code, it seems it will inject
something if there is an authentication plugin enabled. I don't want to remove
it entirely, maybe this was not an accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
