stillalex commented on code in PR #1884:
URL: https://github.com/apache/solr/pull/1884#discussion_r1315833419
##########
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestDistributedTracing.java:
##########
@@ -201,7 +201,7 @@ private void assertOneSpanIsChildOfAnother(List<SpanData>
finishedSpans) {
assertEquals(child.getTraceId(), parent.getTraceId());
}
- private List<SpanData> getAndClearSpans() {
+ static List<SpanData> getAndClearSpans() {
Review Comment:
not a hack, it's an utility method. and not a mock tracer, a real in memory
SpanExporter that is used for testing. I don't disagree with the JUnit rule
though, seems like a good construct but these are only 2 tests if the otel test
pool grows bigger sure, I will keep it in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
