tomglk commented on PR #1883: URL: https://github.com/apache/solr/pull/1883#issuecomment-1712489366
I agree to your reasoning and like your changes in 31eff54 ! Moving the setup of doc 21 into the helper function makes total sense. :) The assert for the used scorer is a bit hidden now. I fear that for others it would not be obvious at first glance what the tests want to test. I moved it out of the helper function in ffea1a8. Does that make sense to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
