cpoerschke commented on PR #1883: URL: https://github.com/apache/solr/pull/1883#issuecomment-1713645754
> The assert for the used scorer is a bit hidden now. I fear that for others it would not be obvious at first glance what the tests want to test. ... Yes, I agree that the assert in the helper method reduces test comprehension, and also the extra `expectedUsedScorerClass` parameter seemed a bit tedious. https://github.com/apache/solr/pull/1883/commits/cf1ed8f84066e7b8c69fe92a4c11ae3a41785689 builds on your change i.e. the assert is moved but the `ObservingFieldValueFeature.usedScorerClass` reading is retained near the `ObservingFieldValueFeature.usedScorerClass = null` clearing - WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
