janhoy opened a new pull request, #1924: URL: https://github.com/apache/solr/pull/1924
https://issues.apache.org/jira/browse/SOLR-16981 ``` bin/solr stop -h Usage: solr stop [-k key] [-p port] [-all] [-V] -k <key> Stop key; default is solrrocks -p <port> Specify the port the Solr HTTP listener is bound to -all Find and stop all running Solr servers on this host -V/-verbose Verbose messages from this script NOTE: To see if any Solr servers are running, do: solr status ``` The behavior with only `solr stop` is not clearly documented, but it can be seen from [script comments](https://github.com/apache/solr/blob/main/solr/bin/solr#L1469-L1470) that the intent is that a pure `solr stop` will check PIDs, and if exactly one is found, it will stop it. If more are found, it will abort and ask user to pass `-all`. However, if the `SOLR_HOME` env var is set (as it e.g. is in docker), and the running solr is on another port, the `solr stop` command will output "No process found for Solr node running on 8983". Thus it is interpreted the same way as if `solr stop -p 8983` was passed. I feel this is confusing, and this PR fixes it by requiring an explicit `-p` switch for that behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
