HoustonPutman commented on PR #1924: URL: https://github.com/apache/solr/pull/1924#issuecomment-1719907109
> LGTM. > > I like seeing the elimination of that werid "PROVIDED_SOLR_PORT" variable! The variable is still being used. If you provide `-p` to `solr stop`, it will set it in the PROVIDED_SOLR_PORT variable. > We can also explore how the stop -all command can have a fallback to use ps as the status command has, if no PIDs are found... The package command already does this (which I don't think it should), so it would be easy to port that code over to the stop command. I don't even think it's worth keeping the PID code. We should just use `ps`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
