dsmiley commented on code in PR #1943:
URL: https://github.com/apache/solr/pull/1943#discussion_r1332091693
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1299,5 +1301,15 @@ public Builder withTraceIdGenerationDisabled() {
this.disableTraceIdGeneration = true;
return this;
}
+
+ /**
+ * It only makes sense to call this if we are using the alwaysOn tracer.
this will randomize the
+ * Span::isRecording check for the alwaysOn tracer so we have coverage of
all methods that deal
+ * with span creation without having to enable otel module
+ */
+ private void injectRandomRecordingFlag() {
+ boolean isRecording = LuceneTestCase.random().nextBoolean();
Review Comment:
I believe there is a "rarely()" method or something like that. I think it
should be rare that we add this and not merely 50%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
