stillalex commented on PR #1943:
URL: https://github.com/apache/solr/pull/1943#issuecomment-1728541552

   > but ideally we would inject the propagating tracer and potentially this 
recording flag in an independent way that isn't specific to SolrCloud. Tracing 
isn't specific to SolrCloud! In the mean time, it'd be nice if there was a 
comment to that effect. People learn systems by reading code; someone might 
think tracing is SolrCloud specific seeing this (and be wrong).
   
   we don't disagree. I want to make this available to all testing code, and 
it's easy enough to do so, the current code serves as an example. what is 
confusing is not having a clear indication of what is missing. do you want to 
move this to a better location? please suggest a better place. there is so much 
testing code around I usually get lost in the options and pick one that looks 
'good enough'.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to