epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336078795
########## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java: ########## Review Comment: Do we need this class? Probably, but I wonder if it actually is required with all the other builders we have for Solr Clients? Seems a shame to have "YASCB". _yet another solr client builder_..... ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
