epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336081208
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -266,6 +296,12 @@ public static void main(String[] args) {
clusterId = defaultClusterId;
}
+ if (!res.getString(ARG_USER_DEST).isEmpty() &&
!res.getString(ARG_PASSWORD_DEST).isEmpty()) {
+ String user = res.getString(ARG_USER_DEST);
+ String password = res.getString(ARG_PASSWORD_DEST);
+ scrapeConfiguration.withBasicAuthCredentials(user, password);
Review Comment:
i ended up littering the https://github.com/apache/solr/pull/1954 code iwth
lots of things that look like this too ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
