stillalex commented on PR #1957: URL: https://github.com/apache/solr/pull/1957#issuecomment-1734090616
thank you for the review @epugh! > Awesome work @stillalex .... Have you looked at https://github.com/apache/solr/pull/1954 ([SOLR-14496](https://issues.apache.org/jira/browse/SOLR-14496)) where I took a stab at adding credentials to the SolrCLI? It would be great if we used the same patterns in both there AND here... For example, I went with -u eric:password instead of seperate username and password params, mostly because curl does it that way! I have not, no. will take a look and try to make it consistent with #1954. `-u` style works too I don't have a strong preference here. > Sigh, in looking, looks like we use net.sourceforge.argparse4j instead of commons-cli... Wish we picked one CLI arg parser for them all! strange. did not even notice this until you said it. will try to see how complicated the refactor to commons-cli would be -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
