stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336130056
########## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java: ########## Review Comment: it wires the existing builders with params passed via cli, it didn't fee like a big problem to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org