stillalex commented on code in PR #1959:
URL: https://github.com/apache/solr/pull/1959#discussion_r1337153085
##########
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##########
@@ -65,7 +65,9 @@ void prepareConfiguration(NamedList<?> args) {
setDefaultIfNotConfigured("OTEL_EXPORTER_OTLP_PROTOCOL", "grpc");
setDefaultIfNotConfigured("OTEL_TRACES_SAMPLER", "parentbased_always_on");
setDefaultIfNotConfigured("OTEL_PROPAGATORS", "tracecontext,baggage");
- addOtelResourceAttributes(Map.of("host.name", System.getProperty("host")));
+ if (System.getProperty("host") != null) {
Review Comment:
hmm, I believe I had this in one of my PRs and you said it was not needed
because this property is present everywhere @janhoy :)
I think it was
https://github.com/apache/solr/pull/1841#discussion_r1294442984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
