stillalex commented on code in PR #1959:
URL: https://github.com/apache/solr/pull/1959#discussion_r1337164802
##########
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##########
@@ -65,7 +65,9 @@ void prepareConfiguration(NamedList<?> args) {
setDefaultIfNotConfigured("OTEL_EXPORTER_OTLP_PROTOCOL", "grpc");
setDefaultIfNotConfigured("OTEL_TRACES_SAMPLER", "parentbased_always_on");
setDefaultIfNotConfigured("OTEL_PROPAGATORS", "tracecontext,baggage");
- addOtelResourceAttributes(Map.of("host.name", System.getProperty("host")));
+ if (System.getProperty("host") != null) {
Review Comment:
> And also learnt that Map.of(k,v) does null-check both for key and value.
yeah, this one bit me a few times too. almost all of the immutable
collection utils (like List.of) do not allow nulls. weird rule.
> Although only likely a problem in dev environments, it's nice to fix.
agreed. although my preference would have been a default instead of missing
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
