stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341987057
########## solr/core/src/java/org/apache/solr/cli/PackageTool.java: ########## @@ -342,6 +341,14 @@ public List<Option> getOptions() { .required(false) .desc("Don't prompt for input; accept all default choices, defaults to false.") .longOpt("noprompt") + .build(), + // u was taken, can we change that instead? + Option.builder("credentials") Review Comment: same as above, why not `SolrCLI.OPTION_CREDENTIALS`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org