epugh commented on PR #1954: URL: https://github.com/apache/solr/pull/1954#issuecomment-1743178358
So, one thing I noticed is that the method `withOptionalBasicAuthCredentials` is ONLY on Http2SolrClient.Builder. It isn't on the `HttpSolrClient builder`. Or on some of the other variations like `LBHttpSolrClient` and `LB2HttpSolrClient`. Maybe that's okay.. And if we need basicauth on more builders in the same manner, well, maybe thats for another talk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
