epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1342810570
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ########## @@ -1311,6 +1311,22 @@ public Builder withProxyConfiguration( this.proxyIsSecure = isSecure; return this; } + + /** + * Setup basic authentication from a string formatted as username:password. If the string is + * Null then it doesn't do anything. + * + * @param credentials The username and password formatted as username:password + * @return this Builder + */ + public Builder withOptionalBasicAuthCredentials(String credentials) { Review Comment: See what I added! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org