gerlowskija commented on PR #639: URL: https://github.com/apache/solr-operator/pull/639#issuecomment-1743692444
Two questions I could use a bit of clarity on before this can be merged: 1. How do we want to handle the potential conflict between user-specified env-vars, and values like `.Spec.NumThreads` that are converted into an env-var by the operator? Currently in this PR, the user-specified env-var "wins" that conflict, though I'm not sure that's the best behavior. 2. Does this need a "changes" helm chart entry, or can that be skipped here as this is largely a refactor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
