HoustonPutman commented on PR #639: URL: https://github.com/apache/solr-operator/pull/639#issuecomment-1743716056
> 1. How do we want to handle the potential conflict between user-specified env-vars, and values like `.Spec.NumThreads` that are converted into an env-var by the operator? Currently in this PR, the user-specified env-var "wins" that conflict, though I'm not sure that's the best behavior. I think that user-specified env-vars should win. > 2. Does this need a "changes" helm chart entry, or can that be skipped here as this is largely a refactor? Yeah I guess it doesn't need it, could go either way, so I don't particularly care! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
