dsmiley commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1357356202
##########
solr/core/src/java/org/apache/solr/core/TracerConfigurator.java:
##########
@@ -46,24 +50,49 @@ public static Tracer loadTracer(SolrResourceLoader loader,
PluginInfo info) {
TracerConfigurator configurator =
loader.newInstance(info.className, TracerConfigurator.class);
configurator.init(info.initArgs);
+ ExecutorUtil.addThreadLocalProvider(new ContextThreadLocalProvider());
return configurator.getTracer();
}
if (shouldAutoConfigOTEL()) {
return autoConfigOTEL(loader);
}
if (TRACE_ID_GEN_ENABLED) {
+ ExecutorUtil.addThreadLocalProvider(new ContextThreadLocalProvider());
Review Comment:
Previously (on 9x), we would register this thing if
GlobalTracer.isRegistered. I added that. Here on main... the situation isn't
clear to me. Wouldn't we want the equivalent? For example, I see above
shouldAutoConfigOTEL would *not* set this but don't we want it to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
