dsmiley commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1747589020
Indeed lets just have a PR on the first point: > First, moves the tracing to the lower level InstrumentedHttpListenerFactory and InstrumentedHttpRequestExecutor so it can capture more of the internal communication requests (and cover both client implementations: Jetty Client and Apache Httpclient). Also the primary part of the SOLR-16943 JIRA was to add client side spans, which are not (yet) in this PR, though I could add them still. Oh yeah... but it'd disturb the test. We could separate that and use a new JIRA issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
