dsmiley commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1363159588
##########
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##########
@@ -103,14 +113,14 @@ public VersionInfo(UpdateLog ulog, int nBuckets) {
.get("versionBucketLockTimeoutMs")
.intVal(
Integer.parseInt(System.getProperty(SYS_PROP_BUCKET_VERSION_LOCK_TIMEOUT_MS,
"0")));
- buckets = new VersionBucket[BitUtil.nextHighestPowerOfTwo(nBuckets)];
- for (int i = 0; i < buckets.length; i++) {
- if (versionBucketLockTimeoutMs > 0) {
- buckets[i] = new TimedVersionBucket();
- } else {
- buckets[i] = new VersionBucket();
- }
- }
+ numBuckets = BitUtil.nextHighestPowerOfTwo(nBuckets);
+ // Instead of directly creating the large bucket array which takes 1.5 MB
per SolrCore,
Review Comment:
state the assumption of 65k buckets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
