dsmiley commented on PR #2021: URL: https://github.com/apache/solr/pull/2021#issuecomment-1769085627
My feedback to Bruno today was overall the this Map upgrade to array (the array we have today) seems kind of pointless; sort of inevitable (assuming there is indexing) so why have this earlier Map incarnation. The actual sought-after benefit that would be nice would be to not have the array at all if there is no indexing here. So just a lazy creation of what exists today would be nice. If all we needed was a lock for the ID, we could use just a ConcurrentHashSet of the IDs to represent holding a lock. But clearly there is a "version" being tracked here, which I confess I don't understand the purpose behind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
