dsmiley commented on PR #2086: URL: https://github.com/apache/solr/pull/2086#issuecomment-1823596078
@jdyer1 I strongly recommend against pushing commits to main from your machine. If it were up to me, it'd be made to be impossible to help avoid mistakes. Nowadays we use GitHub which runs some code quality/style checks that would have been in a failing state. They would show on this PR screen here but are now absent because the state transitioned to closed. Once you resolved those things, they would show in green and then you could merge via a Squash-Merge button. It'd also ask for a commit message, which you should then edit. Only the branch_9x backport would you do from your machine, but then only after waiting for a passing build on main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
