janhoy commented on PR #2086: URL: https://github.com/apache/solr/pull/2086#issuecomment-1823635256
I fixed the formatting, but the test changes in this commit still fails errorprone tests ```bash $ gradle solr:core:check -x test -Pvalidation.errorprone=true > Task :solr:core:compileTestJava /Users/janhoy/git/solr/solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java:117: warning: [DirectInvocationOnMock] Methods should not be directly invoked on the mock `mapMock`. Should this be part of a verify(..) call? assertTrue(mapMock.get("foo!") instanceof BlobRepository.BlobContent); ^ (see https://errorprone.info/bugpattern/DirectInvocationOnMock) /Users/janhoy/git/solr/solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java:150: warning: [DirectInvocationOnMock] Methods should not be directly invoked on the mock `mapMock`. Should this be part of a verify(..) call? mapMock.put("foo!", new BlobRepository.BlobContent<BlobRepository>("foo!", blobData)); [...] ``` Perhaps you can revert and then fix in a new PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org