laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1408273641
########## solr/server/scripts/cloud-scripts/zkcli.sh: ########## @@ -13,6 +13,21 @@ log4j_config="file:$sdir/../../resources/log4j2-console.xml" solr_home="$sdir/../../solr" +# Get solr dir with fullpath Review Comment: Thank you @HoustonPutman for looking at this Little background: We discussed this last year if you remember as part of a bigger [PR](url). The [issue](https://github.com/apache/solr/pull/826#discussion_r866120289) we faced at that time was that SolrJ doesn't "see" the libraries part of the other modules as Solr default class loader does't load classes from different modules. We decided at that time to split the contrib into small ones to make that possible. One of those contribs (that answers your question) is this this [one](https://github.com/apache/solr/pull/1508). It enables passing a custom Solr loader to SolrZKClient. To answer your question: - It's not possible to rely on _solr.xml_ for the reason explained [here](https://github.com/apache/solr/pull/826#discussion_r867412360). - _ZKCli_ and _SolrCli_ don't use _solr.modules_ directly but via _NodeConfig_. _NodeConfig_ reads _solr.modules_ passed through SOLR_MODULES in zkcli.* or solr.in.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
