laminelam commented on code in PR #1994:
URL: https://github.com/apache/solr/pull/1994#discussion_r1408284705
##########
solr/server/scripts/cloud-scripts/zkcli.sh:
##########
@@ -23,6 +38,10 @@ solr_home="$sdir/../../solr"
#...
# -DzkDigestCredentialsFile=/path/to/zkDigestCredentialsFile.properties
#...
+# see the Solr documentation for the other available options
+
+# SOLR_MODULES=aws-secret-provider
+
PATH=$JAVA_HOME/bin:$PATH $JVM $SOLR_ZK_CREDS_AND_ACLS $ZKCLI_JVM_FLAGS
-Dlog4j.configurationFile=$log4j_config -Dsolr.home=$solr_home \
--classpath
"$sdir/../../solr-webapp/webapp/WEB-INF/lib/*:$sdir/../../lib/ext/*:$sdir/../../lib/*"
org.apache.solr.cloud.ZkCLI ${1+"$@"}
+-Dsolr.install.dir=$SOLR_DIR -Dsolr.modules=$SOLR_MODULES -classpath
"$sdir/../../solr-webapp/webapp/WEB-INF/lib/*:$sdir/../../lib/ext/*:$sdir/../../lib/*"
org.apache.solr.cloud.ZkCLI ${1+"$@"}
Review Comment:
The operator has to set _SOLR_MODULES_ in _zkcli.*_
In the same way we expect it in _solr.in.*_ to enable different modules.
We'll add the missing quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
