cpoerschke commented on code in PR #2103:
URL: https://github.com/apache/solr/pull/2103#discussion_r1412026892
##########
solr/core/src/java/org/apache/solr/response/DocsStreamer.java:
##########
@@ -221,6 +222,7 @@ public static Object getValue(SchemaField sf,
IndexableField f) {
KNOWN_TYPES.add(LongPointField.class);
KNOWN_TYPES.add(DoublePointField.class);
KNOWN_TYPES.add(FloatPointField.class);
+ KNOWN_TYPES.add(DenseVectorField.class); // DenseVectorField extends
FloatPointField
Review Comment:
Interesting question.
So one could think that because the dense vector field is a float point
field then it would automatically be known already and there's no need to have
the extra entry. However that is not the case based on the current usage
because the check is a `KNOWN_TYPES.contains` rather than a `instanceof
known_type for all KNOWN_TYPES elements` check (and it would be inefficient to
switch to an `instanceof` check).
Do you think it would be clearer to remove the comment, or to (somehow)
rephrase it instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
