janhoy commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441659284


##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -929,8 +941,8 @@ public NodeConfig build() {
           metricsConfig,
           cachesConfig,
           tracerConfig,
-          containerPluginsSource,
-          containerPlugins,
+          clusterPluginsSource,
+          clusterSingletonPlugins,

Review Comment:
   You know I like simplifications. So as long as they are handled in the same 
generic way, it would be a welcome change. The devil could be in the details 
when one dives into the task though, so let's postpone it to a separate 
investigation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to