pjmcarthur commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1879279003
I will add the validation. Regarding piggybacking on the existing `disable.configEdit` property, I like the idea, but I have one concern. If there are any Solr deployments out there that set `disable.configEdit` to true and also have cluster plugins installed, they will have issues after this change. The property value of `true` would cause the node config plugin source to be used instead of the ZK plugin source, and any plugins that were configured would not be loaded. Maybe this isn't a real problem, and its unlikely that anyone would configure Solr in this way. You mention the property is not documented, so that could benefit us. I'm not sure how confident we can be about how safe it really is though. I think for that reason I slightly prefer the implicit selection of the pluigin source based on the presence of `clusterSingleton` declarations in solr.xml, but I'm ok to use the `disable.configEdit` property if we think its safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
