dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1914809682
> (Me) The other code path is actually already optimized for rows==0 and no scores The method you are attempting to modify calls `getDocListAndSetNC` when `useFilterCache=false`, which is well optimized for this. > Not sure I agree with that. We should be able to store the result in the queryResultCache so that we don't have to recompute for the same exact query a second time? Okay; I sympathize. Another alteration to my suggestion, is that `queryResultWindowSize` should be ignored when rows=0 to allow us to run this query as fast as possible, even if this means not caching `queryResultWindowSize` docs -- because we'd rather not compute their scores merely to cache something in hopes it might be used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
