risdenk commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1915662767
Updated this based on talking w/ @dsmiley. the `useFilterCache` part I was confused on that it always applies to `q` so my change didn't make sense. I pushed a change that made it clear what `useFilterCache` is always used for `q`. I also made the change to `QueryComponent` to make sure `scores` aren't calculated if `rows=0`. I think there is more here potentially. TODO: * Look at adding some more tests * Try adding a benchmark for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
