[ 
https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820719#comment-17820719
 ] 

Gus Heck commented on SOLR-17158:
---------------------------------

{quote}FYI, it was necessary to add this parameter in SOLR-17172, I used 
{{partialResults=true}} to mean that we should stop processing and return 
partial results with "success" code and "partialResults" flag in the response, 
and {{partialResults=false}} to mean that we should throw an exception and 
discard any partial results.
{quote}
I agree that the request should have a parameter to control this behavior as 
well as providing a syprop to determine the result. I am setting it up such 
that the parameter takes precedence over the syprop which only determines 
default behavior if the parameter is not supplied.  May be a complicated merge. 
I've got things like this
{code:java}
if (thereArePartialResults && !rb.req.shouldDiscardPartials()) { {code}
That method will want to be use everywhere because it encapsulates logic for 
both syprop and params.

> Terminate distributed processing quickly when query limit is reached
> --------------------------------------------------------------------
>
>                 Key: SOLR-17158
>                 URL: https://issues.apache.org/jira/browse/SOLR-17158
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Query Limits
>            Reporter: Andrzej Bialecki
>            Assignee: Gus Heck
>            Priority: Major
>
> Solr should make sure that when query limits are reached and partial results 
> are not needed (and not wanted) then both the processing in shards and in the 
> query coordinator should be terminated as quickly as possible, and Solr 
> should minimize wasted resources spent on eg. returning data from the 
> remaining shards, merging responses in the coordinator, or returning any data 
> back to the user.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to