[
https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833972#comment-17833972
]
Gus Heck commented on SOLR-17158:
---------------------------------
Even prior to this change success/fail is a more limited concept than the
actual behavior... Requests may:
Fail - due to syntax, etc (400x)
Fail - due to server issues (500x)
Fail - due to upstream node server issues (500x) (shards.tolerant not set)
Succeed, returning all results (200)
Succeed, returning partial results due to any of the following cases where solr
is doing what we told it to
* Query Limit (timeAllowed, cpuAllowed) (200)
* Upstream node server returns 500 and shards.tolerant=true (200)
* Query cancellation (200)
All of those rely on the partialResults attribute, and the code has logic that
relies on the attribute after we no longer know why it was set, so this
parameter will have the effect of preventing partial results for all of these
cases. I have a specific check to return an error (400, bad request) if this
attribute is set at the same time as shards.tolerant because those to notions
clearly conflict.
> Terminate distributed processing quickly when query limit is reached
> --------------------------------------------------------------------
>
> Key: SOLR-17158
> URL: https://issues.apache.org/jira/browse/SOLR-17158
> Project: Solr
> Issue Type: Sub-task
> Components: Query Limits
> Reporter: Andrzej Bialecki
> Assignee: Gus Heck
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Solr should make sure that when query limits are reached and partial results
> are not needed (and not wanted) then both the processing in shards and in the
> query coordinator should be terminated as quickly as possible, and Solr
> should minimize wasted resources spent on eg. returning data from the
> remaining shards, merging responses in the coordinator, or returning any data
> back to the user.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
