epugh commented on code in PR #2329: URL: https://github.com/apache/solr/pull/2329#discussion_r1510001348
########## solr/CHANGES.txt: ########## @@ -27,7 +27,8 @@ Optimizations Bug Fixes --------------------- -(No changes) + +* PR#2329: Fix getting fieldType by its name in FileBasedSpellChecker (Andrey Bozhko) Review Comment: I *believe* we normally create a JIRA for these user facing, so we can track which version of Solr it gets released. The pattern has recently become a bit muddier... non user facing changes sometimes skipping JIRA.. If you add a JIRA, then that makes it easier for me to merge this! ########## solr/core/src/test-files/solr/collection1/conf/schema-spellchecker.xml: ########## @@ -49,9 +49,22 @@ </analyzer> </fieldType> + <fieldType name="teststop_type" class="solr.TextField"> Review Comment: I haven't checked in more detail, but don't we normally camelCase? testStopType ??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org