AndreyBozhko commented on code in PR #2329: URL: https://github.com/apache/solr/pull/2329#discussion_r1511715637
########## solr/CHANGES.txt: ########## @@ -27,7 +27,8 @@ Optimizations Bug Fixes --------------------- -(No changes) + +* PR#2329: Fix getting fieldType by its name in FileBasedSpellChecker (Andrey Bozhko) Review Comment: I submitted a request for a JIRA account, will open the issue once the account is set up ########## solr/core/src/test-files/solr/collection1/conf/schema-spellchecker.xml: ########## @@ -49,9 +49,22 @@ </analyzer> </fieldType> + <fieldType name="teststop_type" class="solr.TextField"> Review Comment: I saw that in different test files, the fields and field types appear in either camel case or snake case (an sometimes even in kebab case). I personally use snake case, and I believe the Ref Guide examples also suggest snake case (e.g., field types `text_general` or `text_ws`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org