uschindler commented on PR #2360: URL: https://github.com/apache/solr/pull/2360#issuecomment-2010214595
> Maybe we should assign a per-project `ext.javaVersion` in the general settings file in the gradle root folder once and reuse it at all places where `rootProject.minJavaVersion` was used. Yes, I would do the following: - Move the code which defines the Java version per project to `gradle/globals.gradle`. Maybe define it there and also use it in rootProject. Assign it to `ext.minJavaVersion` - Remove definition of minJavaVersion in the root project (so it only exists in `globals.gradle`) - grep through all grade files and replace `rootProject.manJavaVersion` by `project.minJavaVersion` This is much cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
