janhoy commented on PR #2360: URL: https://github.com/apache/solr/pull/2360#issuecomment-2039249157
Probably let features like this be driven by user demand. If no user/committer requests aws-cred handled by SolrJ client side, let's not do it. But if there is a need, then the module could be split in two, one client-only part and one server-side module that depends on the client-part. I thought of another issue with having different JDK requirements for solrj and core. When we do breaking upgrades of e.g. jetty on the server side, that same version of jetty-client will also be mandated on the client, even if client runs with JDK11. Guess it is a different but related issue. If we sometimes would like to ship SolrJ with an older jetty requirement for compatibility with Spring Framework or similar. That is harder to do though, as we'd likely need to have a separate gradble build for solrj and perhaps even multiple releases like "solrj-jetty10" and "solrj-jetty12", where solr server includes the jetty12 variant... Let's not go there just yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
