gerlowskija commented on PR #2395: URL: https://github.com/apache/solr/pull/2395#issuecomment-2047973430
This should all be ready to go: I've added unit and integration tests, `./gradlew test` passes, there's ref-guide coverage and decent Javadocs, etc. I'll aim to merge EOW, absent any feedback folks might have here. One big question I have is: should we add this into the "_default" configset's default URP-chain? At least for 10.x? I'd argue we should. Safety guardrails like this one aren't any good unless users enable them, and having it be enabled by default is the best way to do that. We might get some complaints from folks who run into this during an inplace 9->10 upgrade, but: 1. We tell users to carefully reconsider their configsets when doing upgrades, so this shouldn't be a surprise. 2. We can highlight it clearly in the upgrade notes 3. Users who hit this on an in-place upgrade can always bump the limit, toggle the URP into 'warnOnly' mode, or disable the URP altogether if they really want. I'd love a sanity-check/+1 from someone else though before I make this enabled by default on `main`/10.x, so please chime in! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
