magibney commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1574789547
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1278,6 +1287,15 @@ public Builder withMaxConnectionsPerHost(int max) {
return this;
}
+ /**
+ * Specify the maximum number of concurrent asynchronous requests the
client can send. The
+ * default value is 1000
+ */
+ public Builder withMaxOutstandingRequests(int max) {
Review Comment:
Yeah, it's really 2 things:
1. throttles maximum number of outstanding requests across all hosts
2. the number of requests per host that will be buffered waiting to send,
once 1. hits its limit.
2. does buffering, but no actual throttling, and IMO it's not useful. If we
proceed with making the "per host" part hardcoded (removing 2.), then the
javadocs here for `withMaxOutstandingRequests(int)` will be completely
accurate. And as it stands I'd say they're essentially accurate, practically
speaking, since the per-host logic that they do influence is more of an
internal detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
