dsmiley commented on code in PR #2313: URL: https://github.com/apache/solr/pull/2313#discussion_r1575096509
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ########## @@ -1017,19 +1023,21 @@ public String getBaseURL() { } private static class AsyncTracker { - private static final int MAX_OUTSTANDING_REQUESTS = 1000; + private static final int DEFAULT_MAX_OUTSTANDING_REQUESTS = 1000; Review Comment: Isn't the "solrj" part important though? The component name following "solr" is important to categorize this setting. Simply omitting "solrj" would make "async" the category, which is a bad name IMO. I think "solrj" is a good category name and it should be chosen. See https://cwiki.apache.org/confluence/display/SOLR/System+property+naming+structure CC @janhoy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org