iamsanjay commented on code in PR #2460:
URL: https://github.com/apache/solr/pull/2460#discussion_r1605693730
##########
solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java:
##########
@@ -361,12 +360,11 @@ private void requestRecovery(
RequestRecovery recoverRequestCmd = new RequestRecovery();
recoverRequestCmd.setAction(CoreAdminAction.REQUESTRECOVERY);
recoverRequestCmd.setCoreName(coreName);
-
try (SolrClient client =
- new HttpSolrClient.Builder(baseUrl)
- .withHttpClient(SyncStrategy.this.client)
+ new Http2SolrClient.Builder(baseUrl)
Review Comment:
> Should this be merged or should it be pending some
authentication/authorization fix?
Pending due to auth issue. Wherever we are re-creating the Http2SolrClient
and in SyncStrategy we are -- because of custom timeouts. This code for adding
listener factory (Builder#withListenerFactory) seems a broken window to me as
there is no way to enforce it and can be easily missed in future. @dsmiley We
had discussion regarding the timeouts handling at request level then we don't
need to re-create the client.
Other option that I am also in favour of is to copy variable via calling
`withHttpClient(solrClient)` as we are already doing with other configuration.
https://github.com/apache/solr/blob/6af52f33ac78155523ec6fc610c563127b81c139/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java#L1033-L1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
