dsmiley commented on code in PR #2460:
URL: https://github.com/apache/solr/pull/2460#discussion_r1605941717
##########
solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java:
##########
@@ -361,12 +360,11 @@ private void requestRecovery(
RequestRecovery recoverRequestCmd = new RequestRecovery();
recoverRequestCmd.setAction(CoreAdminAction.REQUESTRECOVERY);
recoverRequestCmd.setCoreName(coreName);
-
try (SolrClient client =
- new HttpSolrClient.Builder(baseUrl)
- .withHttpClient(SyncStrategy.this.client)
+ new Http2SolrClient.Builder(baseUrl)
Review Comment:
Shouldn't withHttpClient copy *everything* over, including the
ListenerFactory? It's worthy of its own JIRA/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
