AndreyBozhko commented on code in PR #2471: URL: https://github.com/apache/solr/pull/2471#discussion_r1617546510
########## solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java: ########## @@ -694,9 +694,14 @@ public <T> boolean addToCoreAware(T obj) { } } + void initConfig(SolrConfig config) { + assert this.config == null || this.config == config; Review Comment: Based on the code observation, an instance of SolrConfig is always created via `SolrConfig#readFromResourceLoader` or the public "use-in-tests-only" ctor - and at the call sites, there's always a new instance of SolrResourceLoader being created. So that indicates to me that the lifecycles of the config and the loader are naturally tied together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org