gerlowskija commented on PR #2471: URL: https://github.com/apache/solr/pull/2471#issuecomment-2139661307
Hi @AndreyBozhko - sorry for the delay in unblocking this. The reason your test started failing is that [my recent commit](https://github.com/apache/solr/commit/8c5ae1bb745869ebd6fab5911b3dd0fd75ed9106) subtly changed the "upload filestore" response in some cases. The response would still serialize to the same JSON or XML, but the "javabin" now parses a bit differently when received on the client side. This breaks a class/type expectation baked into the SolrResponseBase getters and triggers the ClassCastException you observed. This is a known issue right now with 'javabin' and our JAX-RS v2 APIs that we'll need to come up with a fix for at some point, if we decide to keep "javabin" in 10.0. It seemed at first like something that'd be easy to workaround, but each thing I tried uncovered a different bug 😬 1. The standard workaround would be to ditch V2Request and instead use `FileStoreApi.Upload`, a SolrRequest implementation that's generated for us based on the v2 API definition. But this didn't work due to [an issue with our generation template](https://github.com/apache/solr/pull/2470#issuecomment-2139638871). 2. A solid second-tier workaround would be to modify V2Request usage to use a different response format (e.g. JSON or XML). But it turns out that [the type/class assumptions made by SolrResponseBase.getStatus also break when JSON or XML are used](https://issues.apache.org/jira/browse/SOLR-17316)! (Note that afaict this error happens any time JSON or XML are used - for any API, either v1 or v2, with or without my recent PR!) 3. Due to an embarrassing little coding error, v2 APIs respond with XML when wt=json is specified 😬 . I've filed a bug report for this [here](https://issues.apache.org/jira/browse/SOLR-17317) Long story short, I intend to fix all these bugs, but I don't want to keep you blocked while I do. Will revert shortly and then you should be unblocked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
