dsmiley commented on code in PR #2491:
URL: https://github.com/apache/solr/pull/2491#discussion_r1623635690
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -373,11 +373,48 @@ public void init(PluginInfo info) {
*/
public void init(UpdateHandler uhandler, SolrCore core) {
dataDir = core.getUlogDir();
-
this.uhandler = uhandler;
+ // on a reopen, return early; less work to do.
+ // note: that method can update this.dataDir
+ if (initCheckRepoen(core)) return;
+
+ initTlogDir();
+
usableForChildDocs = core.getLatestSchema().isUsableForChildDocs();
+ try {
Review Comment:
this is just moved code, but the diff can't show that
##########
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##########
@@ -215,40 +211,6 @@ public void init(UpdateHandler uhandler, SolrCore core) {
ll.closeOutput();
}
}
-
Review Comment:
this was all that duplicated code, the point of this refactoring/PR
##########
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##########
@@ -81,31 +77,15 @@ public void init(PluginInfo info) {
log.info("Initializing HdfsUpdateLog: tlogDfsReplication={}",
tlogDfsReplication);
}
- private Configuration getConf(Path path) {
Review Comment:
simply re-ordered this below when it's called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
