magibney commented on code in PR #2491:
URL: https://github.com/apache/solr/pull/2491#discussion_r1628080442
##########
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##########
@@ -81,31 +77,15 @@ public void init(PluginInfo info) {
log.info("Initializing HdfsUpdateLog: tlogDfsReplication={}",
tlogDfsReplication);
}
- private Configuration getConf(Path path) {
- Configuration conf = new Configuration();
- if (confDir != null) {
- HdfsUtil.addHdfsResources(conf, confDir);
- }
-
- String fsScheme = path.toUri().getScheme();
- if (fsScheme != null) {
- conf.setBoolean("fs." + fsScheme + ".impl.disable.cache", true);
- }
- return conf;
- }
-
@Override
- public void init(UpdateHandler uhandler, SolrCore core) {
-
- // ulogDir from CoreDescriptor overrides
- String ulogDir = core.getCoreDescriptor().getUlogDir();
-
- this.uhandler = uhandler;
-
+ protected boolean initCheckRepoen(SolrCore core) {
synchronized (fsLock) {
// just like dataDir, we do not allow
// moving the tlog dir on reload
if (fs == null) {
+ // ulogDir from CoreDescriptor overrides
+ String ulogDir = core.getCoreDescriptor().getUlogDir();
Review Comment:
There's some weird overlap between this PR and #1895 -- it's taking me a
while to make sense of the relationships here, so thanks for bearing with me 😬 .
For all the work I've put into this area of the code recently, it's still
quite confusing, and I'm hoping that this PR will help clarify things. I
hesitate to suggest, but I'm wondering if it might be better to incorporate
this refactor into #1895, since I'm not sure it makes sense to do a rote
refactor of code that is iirc basically buggy. I'm taking a stab at what that
would look like now, mainly to better understand the code.
I'll follow up soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
